Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Custom error messages for Duck Player #1421

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Jan 22, 2025

Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1208283441580816/f

Description

  • Shows error custom message when YouTube error is detected within embed iframe

Testing Steps

  • TBC

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@mgurgel mgurgel self-assigned this Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit fc34ba7
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/679ab294a8399d00080ac24e
😎 Deploy Preview https://deploy-preview-1421--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 22, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 22, 2025

[Beta] Generated file diff

Time updated: Wed, 29 Jan 2025 22:59:31 GMT

Android
    - android/pages/duckplayer/dist/index.css
  • android/pages/duckplayer/dist/index.js
  • android/pages/duckplayer/locales/en/duckplayer.json

File has changed

Integration
    - integration/pages/duckplayer/dist/index.css
  • integration/pages/duckplayer/dist/index.js
  • integration/pages/duckplayer/locales/en/duckplayer.json

File has changed

Windows
    - windows/pages/duckplayer/dist/index.css
  • windows/pages/duckplayer/dist/index.js
  • windows/pages/duckplayer/locales/en/duckplayer.json

File has changed

Apple
    - dist/pages/duckplayer/dist/index.css
  • dist/pages/duckplayer/dist/index.js
  • dist/pages/duckplayer/index.html
  • dist/pages/duckplayer/locales/en/duckplayer.json

File has changed

@mgurgel mgurgel force-pushed the mgurgel/duckplayer-login branch from f1cd8dc to fc34ba7 Compare January 29, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant