Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cert location based on where they actually are in the filesystem #20

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nicklan
Copy link
Collaborator

@nicklan nicklan commented Nov 7, 2024

This works, but will search the FS on every request.

Looking for guidance on the idiomatic way in a DuckDB extension to store this between calls.

@samansmink
Copy link
Collaborator

In the Azure extension we use the ClientContext::registered_state for this, see here

This is likely the cleanest way to solve this, but perhaps a little overkill for the prototyping state of the extension and might lead to double work if we end up refactoring.

Alternatively perhaps for now its fine to search the FS on every request or perhaps doing it once on extension load storing the resulting path in a global variable. Note that because the extension initialization function is guaranteed to be the first thing that is called and will never be called again, this is safe to do without locking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants