Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and deploy DuckDB-Wasm extensions #46

Merged
merged 10 commits into from
Nov 29, 2023

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Nov 24, 2023

NOTE: Last commit has to be reverted, moving to main once duckdb/duckdb#9356 is merged

Build step is tested, signing step is tested (but for verifying the binaries are actually valid, need to add that), deploy step untested.

DuckDB side PR has been merged, bumped to main the workflow.

@carlopi carlopi changed the title Build and deploy DuckDB-Wasm extensions [DO NOT MERGE YET] Build and deploy DuckDB-Wasm extensions Nov 24, 2023
@carlopi
Copy link
Contributor Author

carlopi commented Nov 28, 2023

I did ended up testing also the deploy, once it's green here it should be good to go.

Right now, on the live shell.duckdb.org:

duckdb> SET custom_extension_repository='https://nightly-extensions.duckdb.org';
duckdb> LOAD quark;
duckdb> SELECT quark('XXX');
┌──────────────┐
│ quark('XXX') │
╞══════════════╡
│ Quark XXX 🐥  │
└──────────────┘
Elapsed: 28 ms

duckdb> 

Copy link
Collaborator

@samansmink samansmink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @carlopi looks good! very excited to have this working. I added two small comments!

.github/workflows/_extension_deploy_wasm.yml Outdated Show resolved Hide resolved
.github/workflows/MainDistributionPipeline.yml Outdated Show resolved Hide resolved
@samansmink samansmink merged commit ab2cc0c into duckdb:main Nov 29, 2023
13 of 15 checks passed
@samansmink
Copy link
Collaborator

Good stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants