-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and deploy DuckDB-Wasm extensions #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlopi
force-pushed
the
buildanddeploywasm
branch
from
November 24, 2023 09:38
7f18ee8
to
c6988c5
Compare
carlopi
force-pushed
the
buildanddeploywasm
branch
from
November 24, 2023 10:22
c6988c5
to
7df882e
Compare
carlopi
changed the title
Build and deploy DuckDB-Wasm extensions [DO NOT MERGE YET]
Build and deploy DuckDB-Wasm extensions
Nov 24, 2023
I did ended up testing also the deploy, once it's green here it should be good to go. Right now, on the live shell.duckdb.org:
|
samansmink
reviewed
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @carlopi looks good! very excited to have this working. I added two small comments!
carlopi
force-pushed
the
buildanddeploywasm
branch
from
November 29, 2023 13:05
8763abc
to
a24f7a9
Compare
Good stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Last commit has to be reverted, moving to main once duckdb/duckdb#9356 is merged
Build step is tested, signing step is tested (but for verifying the binaries are actually valid, need to add that), deploy step untested.
DuckDB side PR has been merged, bumped to main the workflow.