Make sure vcpkg uses the rtools toolchain instead of windows mingw #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samansmink
reviewed
Sep 20, 2024
JAicewizard
force-pushed
the
fix_vcpkg
branch
from
47df24d
to
13df2dd
Compare
vcpkg doesnt detect the rtools mingw toolchain, which causes issues in the faiss extension.
JAicewizard
force-pushed
the
fix_vcpkg
branch
from
13df2dd
to
0a5e5be
Compare
|
Ah crap, you're right, this was a sloppy PR |
|
no worries! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vcpkg doesnt detect the rtools mingw toolchain, which causes issues in the faiss extension.