Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to enable extra toolchains, deprecated enable_rust #53

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

samansmink
Copy link
Collaborator

This will allow us to add more toolchains dynamically to enable more flexibility in building extensions that require extra toolchain setup.

We reduce the risk of an extension requiring some toolchain to be present to break other extension's CI

Copy link
Collaborator

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

@samansmink
Copy link
Collaborator Author

ci failure unrelated

@samansmink samansmink merged commit ebf18ed into duckdb:main Jul 12, 2024
18 of 19 checks passed
@samansmink samansmink deleted the add-extra-toolchains-option branch July 12, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants