Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom linker #52

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Allow custom linker #52

merged 1 commit into from
Jul 12, 2024

Conversation

Wal8800
Copy link

@Wal8800 Wal8800 commented Jul 11, 2024

Currently, when using the default linker ld, it creates a large spike of memory usage during the linking step. This is on Ubuntu 22.04.

image

When I switch to using mold, it use significantly less memory

image

Proposing to add CUSTOM_LINKER option so we can run the make command like CUSTOM_LINKER=mold make

Discord conversation for reference: https://discord.com/channels/909674491309850675/1209495191380172862/1260829046217113711

@Wal8800 Wal8800 changed the title Allow customer linker Allow custom linker Jul 11, 2024
@samansmink samansmink merged commit 0b468fc into duckdb:main Jul 12, 2024
18 of 19 checks passed
@samansmink
Copy link
Collaborator

CI failure unrelated LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants