More fixes for Wasm builds, and move configure one layer up #106
Conversation
| @@ -58,6 +58,8 @@ endif | |||
| # Write the platform we are building for | |||
| platform: configure/platform.txt | |||
|
|
|||
| configure: venv platform extension_version | |||
There was a problem hiding this comment.
configure should be a target defined in the extension repository I think: This way you can override the target easily without requiring to inline the whole makefile
|
|
||
| wasm_mvp: | ||
| DUCKDB_PLATFORM=wasm_mvp make configure release move_wasm_extension |
There was a problem hiding this comment.
Perhaps the wasm_mvp, wasm_eh wasm_threads targets can stay in the main makefile? I think that's a decently clean split? that way we do move the internals into extension-ci-tools but the extension repo can still control what is done for those targets.
There was a problem hiding this comment.
Just to be clear, you mean moving:
+wasm_mvp:
+ DUCKDB_PLATFORM=wasm_mvp make configure release move_wasm_extension
+
+wasm_eh:
+ DUCKDB_PLATFORM=wasm_eh make configure release move_wasm_extension
+
+wasm_threads:
+ DUCKDB_PLATFORM=wasm_coi make configure release move_wasm_extension
to the extension own makefile, and keeping the infra here?
There was a problem hiding this comment.
I think we agreed: wasm_* targets stay in the inner makefiles, users are supposed to invoke it like:
DUCKDB_PLATFORM=wasm_eh make configure release
carlopi
force-pushed
the
more_fixes_wasm
branch
from
0c59a3b
to
ce31455
Compare
|
lgtm! |
This PR allows to remove
configuretarget from extension-template-rs, and have the wasm logic moved completely to the template.