Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to enable building for Wasm targets #105

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Fixes to enable building for Wasm targets #105

merged 5 commits into from
Nov 13, 2024

Conversation

carlopi
Copy link
Collaborator

@carlopi carlopi commented Nov 12, 2024

No description provided.

@carlopi
Copy link
Collaborator Author

carlopi commented Nov 12, 2024 •
edited
Loading

I tested this using extension-template-rs built for wasm_eh.

extension-template-rs needs a couple of more changes, that I think are relevant only there but I have not finalized, on top of this to work out of the box.

I have to say structure of the makefiles is very pleasant and makes sense.

@carlopi carlopi merged commit 5bdbe4d into duckdb:main Nov 13, 2024
19 checks passed
@carlopi carlopi deleted the fixes_wasm branch November 13, 2024 00:44
@carlopi carlopi mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samansmink samansmink samansmink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlopi @samansmink