Skip to content

Commit

Permalink
Invert conditions on continue-on-error
Browse files Browse the repository at this point in the history
  • Loading branch information
carlopi committed May 6, 2024
1 parent ae005ae commit 169328a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/NodeJS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
name: node.js Linux
runs-on: ubuntu-20.04
needs: set-up-npm
continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }}
continue-on-error: ${{ matrix.node == '12' || matrix.node == '14' || matrix.node == '16' || matrix.node == '17' }}
env:
TARGET_ARCH: ${{ matrix.target_arch }}
DUCKDB_NODE_BUILD_CACHE: 0
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
name: node.js OSX
runs-on: macos-latest
needs: set-up-npm
continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }}
continue-on-error: ${{ matrix.node == '16' || matrix.node == '17' }}
strategy:
matrix:
target_arch: [ x64, arm64 ]
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
name: node.js Windows
runs-on: windows-latest
needs: set-up-npm
continue-on-error: ${{ matrix.node != '18' && matrix.node != '20' && matrix.node != '21' }}
continue-on-error: ${{ matrix.node == '16' || matrix.node == '17' }}
env:
npm_config_msvs_version: 2019

Expand Down

0 comments on commit 169328a

Please sign in to comment.