Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the docstring of GAM classes #324

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

utopianf
Copy link

According to this code, intercept will be added at the end of self.coef_ (self.coef_[-1]) but not self.coef_[0]

According to https://github.com/dswah/pyGAM/blob/master/pygam/pygam.py#L290, intercept will be added at the end of self.coef_
Copy link

@Wieser145 Wieser145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, has anyone figured out why the calculated intercept is different then that of the mgcv package in R?

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #324 (6ac6625) into master (620958f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          22       22           
  Lines        3208     3208           
=======================================
  Hits         3048     3048           
  Misses        160      160           
Impacted Files Coverage Δ
pygam/pygam.py 94.55% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants