Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #262
I changed the formulas to be single variable functions. I'm not sure if the previous intent was to imply the existence of the two variable 'tensor' functions. If that is in fact the case, then separating the two variable functions out from the single variable would be easier to read:
$$\beta_0 + f_1(X_1) + \ldots + f_M(X_M) + \sum_{j=0}^{M} \sum_{k\neq j} f_{j,k}(X_j, X_k)$$
where the double indices imply the dependance on two variables. It should also probably be mentioned that having the two variable functionality is generalizing beyond your typical GAM, which I believe are only supposed to be single variable functions