Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify order of param validation in gridsearch #251

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dswah
Copy link
Owner

@dswah dswah commented Jul 16, 2019

We need to validate the data-dependent model parameters after validating the data!

this fixes #245 and fixes #246 and fixes #232

@codecov
Copy link

codecov bot commented Jul 16, 2019

Codecov Report

Merging #251 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #251      +/-   ##
=========================================
+ Coverage   95.05%   95.2%   +0.14%     
=========================================
  Files          22      22              
  Lines        3178    3192      +14     
=========================================
+ Hits         3021    3039      +18     
+ Misses        157     153       -4
Impacted Files Coverage Δ
pygam/pygam.py 94.8% <100%> (ø) ⬆️
pygam/tests/test_gridsearch.py 100% <100%> (ø) ⬆️
pygam/utils.py 87.73% <0%> (+0.3%) ⬆️
pygam/tests/test_GAM_methods.py 100% <0%> (+0.36%) ⬆️
pygam/tests/test_utils.py 96.5% <0%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2942579...5cecb3f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant