Refactor plugins to allow reducing dependencies to ddk.xtext and ddk.xtext.builder #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenporras
force-pushed
the
split2
branch
4 times, most recently
from
9fd0cf0
to
cd61c8e
Compare
rubenporras
changed the title
rubenporras
commented
Sep 23, 2024
| @@ -1,83 +1,83 @@ | |||
| /******************************************************************************* | |||
There was a problem hiding this comment.
@andrewL-avlq , all this files look fine in my workspace. Do you know if the old ones have the wrong format?
There was a problem hiding this comment.
They look fine in my workspace too, so not sure what formatting has changed (although I would guess the line endings).
There was a problem hiding this comment.
Actually, I think it is just recording the files that have moved as full diffs.
ddk.xtext.builder
andrewL-avlq
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.