build: Upgrade to Xtext 2.36 #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenporras
force-pushed
the
xtext2_36
branch
9 times, most recently
from
e29c3d3
to
887710f
Compare
Have it leave out ResourceValidationRuleSummaryEvent.Collector from the generated 'validate' method signature so that the checkedTypeRef call to create a JvmTypeReference to the particular inner class cannot fail. That is something that apparently could in some situations happen.
joaodinissf
requested changes
Aug 26, 2024
...xt.test.core/src/com/avaloq/tools/ddk/xtext/test/validation/AbstractValidValidationTest.java
Outdated
Show resolved
Hide resolved
As part of the upgrade, delete the Xtext Spy, which has not been ported to LSP and was using some of the removed APIs in Xtext 2.36.
joaodinissf
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.