Refactor to allow reducing dependencies to ddk.xtext.builder #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenporras
commented
Sep 24, 2024
| @@ -49,7 +47,6 @@ | |||
| * encapsulated index or the issue store are accessed, the platform must be opened through {@link #open(boolean, IProgressMonitor)}. Once open, all operations | |||
| * are allowed. Once it is no longer in use, a platform must be closed through {@link #close(IProgressMonitor)}. | |||
| */ | |||
| @ImplementedBy(DefaultXtextTargetPlatform.class) | |||
There was a problem hiding this comment.
@andrewL-avlq , will I need to bind this now in ASMD or do we have a more specific XtextTargetPlatform?
There was a problem hiding this comment.
I think we do not inject IXtextTargetPlatforms directly, but instead bind the IXtextTargetPlatformFactory and inject/use that instead.
andrewL-avlq
previously approved these changes
Sep 24, 2024
andrewL-avlq
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.