Bump com.puppycrawl.tools:checkstyle from 10.12.1 to 10.12.2 in /ddk-…

…parent (#797)

* Bump com.puppycrawl.tools:checkstyle in /ddk-parent

Bumps [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) from 10.12.1 to 10.12.2.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-10.12.1...checkstyle-10.12.2)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add final modifier
---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: rubenporras <[email protected]>

com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/label/CheckRuleLabelProviderTest.java

@@ -253,7 +253,7 @@ public void testCaching() {
    * {@inheritDoc}
    * Override with invalidateCache() method exposed.
    */
-  private static class CheckRuleLabelProviderWithInvalidateCacheExposed extends CheckRuleLabelProvider {
+  private static final class CheckRuleLabelProviderWithInvalidateCacheExposed extends CheckRuleLabelProvider {
     /**
      * Call protected method {link CheckRuleLabelProvider.invalidateCache}.
      */

com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/util/ErrorLogListener.java

@@ -201,7 +201,7 @@ public void unregister() {
   /**
    * A log listeners listening for logged {@link IStatus}.
    */
-  private class LogListener implements ILogListener {
+  private final class LogListener implements ILogListener {
     /** The list holding the logged status. */
     private final List<IStatus> loggedStatus = new ArrayList<IStatus>();
 

com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java

@@ -627,7 +627,7 @@ private boolean widgetNotFoundExceptionToBoolean(final Supplier<? extends Abstra
   }
 
   /** Helper that doesn't wait for widgets to appear as long as the default settings. */
-  private static class ImpatientSwtWorkbenchBot extends SWTWorkbenchBot {
+  private static final class ImpatientSwtWorkbenchBot extends SWTWorkbenchBot {
     static final long MAX_RETRIES = 4; // Actual number of retries will almost certainly be at least 1 fewer than this.
     static final long SHORT_TIME_OUT = 64;
     static final long SHORT_INTERVAL = SHORT_TIME_OUT / MAX_RETRIES;

com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/BuiltInTypeModelAccess.java

@@ -14,7 +14,7 @@
 import java.util.Map;
 
 import org.apache.logging.log4j.Logger;
-import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.LogManager;
 import org.eclipse.emf.common.util.URI;
 import org.eclipse.emf.ecore.resource.Resource;
 import org.eclipse.emf.ecore.resource.ResourceSet;
@@ -62,7 +62,7 @@ public final class BuiltInTypeModelAccess {
   /**
    * The singleton instance.
    */
-  private static class InstanceHolder {
+  private static final class InstanceHolder {
     // Initialize-on-demand holder pattern.
     @SuppressWarnings("PMD.AccessorClassGeneration")
     // This is a common idiom, and PMD even says to use it, see http://pmd.sourceforge.net/pmd-5.1.0/rules/java/design.html, Rule NonThreadSafeSingleton

com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/contentassist/AbstractAcfContentAssistTest.java

@@ -330,7 +330,7 @@ protected int expectedExactly(final int markerId, final String... proposals) {
    * This class preserves information about tags in the sources for all tests within
    * a content assist test class.
    */
-  private class AcfContentAssistMarkerTagsInfo extends MarkerTagsInfo {
+  private final class AcfContentAssistMarkerTagsInfo extends MarkerTagsInfo {
     private final Map<Integer, String[]> expectedProposalMap = Maps.newHashMap();
     private final Map<Integer, String[]> notExpectedProposalMap = Maps.newHashMap();
     private final Map<Integer, String[]> expectedExactlyProposalMap = Maps.newHashMap();

com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/ui/occurrences/AbstractOccurrencesTest.java

@@ -79,7 +79,7 @@ public String noSemantic() {
   /**
    * Stores occurrences to be checked.
    */
-  private static class OccurrencesToCheck {
+  private static final class OccurrencesToCheck {
     private int cursorOffset;
     private final Set<Integer> semanticMarkers = Sets.newHashSet();
     private final Set<Integer> noSemanticMarkers = Sets.newHashSet();

com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/AbstractFragmentProviderTest.java

@@ -22,7 +22,7 @@ public class AbstractFragmentProviderTest {
 
   private static final String[] SPECIAL_ESCAPE_CASES = new String[] {"\\", "\\\\", "\\\\\\", "\\#", "\\\\#", "\\\\\\#", "#", "##", "#\\"};
 
-  private static class TestAbstractFragmentProvider extends AbstractFragmentProvider {
+  private static final class TestAbstractFragmentProvider extends AbstractFragmentProvider {
 
     @Override
     public boolean appendFragmentSegment(final EObject object, final StringBuilder builder) {

com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/linking/ShortFragmentProviderTest.java

@@ -35,7 +35,7 @@ public class ShortFragmentProviderTest extends AbstractTest {
 
   private static AbstractTestUtil testUtil = new AbstractTestUtil() {};
 
-  private static class TestFallbackFragmentProvider implements IFragmentProvider.Fallback {
+  private static final class TestFallbackFragmentProvider implements IFragmentProvider.Fallback {
 
     @Override
     public String getFragment(final EObject obj) {

com.avaloq.tools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/AbstractSelectorFragmentProviderTest.java

@@ -89,7 +89,7 @@ private void assertFragmentMatchesAndResolves(final Resource res, final String e
     assertSame(obj, res.getEObject(fragment));
   }
 
-  private static class TestSelectorFragmentProvider extends AbstractSelectorFragmentProvider {
+  private static final class TestSelectorFragmentProvider extends AbstractSelectorFragmentProvider {
 
     @Override
     public boolean appendFragmentSegment(final EObject object, final StringBuilder builder) {

com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/caching/CacheManager.java

@@ -20,7 +20,7 @@
 import java.util.concurrent.TimeUnit;
 
 import org.apache.logging.log4j.Logger;
-import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.LogManager;
 import org.eclipse.emf.ecore.resource.Resource;
 
 import com.avaloq.tools.ddk.xtext.naming.QualifiedNameLookup;
@@ -257,7 +257,7 @@ public void run() {
   /**
    * {@link CacheStatistics} representing the statistics coming from multiple caches.
    */
-  private class MultiCacheStatistics extends CacheStatistics {
+  private final class MultiCacheStatistics extends CacheStatistics {
     private int counter;
 
     @Override

com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/serializer/sequencer/ReorderingHiddenTokenSequencer.java

@@ -743,7 +743,7 @@ private List<INode> getRemainingHiddenNodesInContainer(final INode from, final I
   /**
    * Auxiliary leaf node subtype used to indicate that a new line must be inserted at some point.
    */
-  private static class LeadingCommentsMarkerNode extends LeafNode {
+  private static final class LeadingCommentsMarkerNode extends LeafNode {
     @Override
     public String getText() {
       return NEW_LINE;

ddk-parent/pom.xml

@@ -47,7 +47,7 @@
 
     <!-- maven plugin versions -->
     <checkstyle.plugin.version>3.3.0</checkstyle.plugin.version>
-    <checkstyle.version>10.12.1</checkstyle.version>
+    <checkstyle.version>10.12.2</checkstyle.version>
     <clean.version>3.2.0</clean.version>
     <deploy.version>3.1.1</deploy.version>
     <spotbugs.plugin.version>4.7.3.5</spotbugs.plugin.version>