Don't use constructor to implement track initialization

pthread_trace.cc

@@ -412,7 +412,10 @@ class incremental_clock {
 static std::atomic<int> next_track_id{0};
 
 class track {
-  circular_file* global_buffer;
+  // This cannot have a constructor, to avoid recursive hook issues with malloc implementations that use functions we
+  // hook. The C++ mechanism to register a destructor at thread exit uses malloc.
+  bool constructed = false;
+  circular_file* global_buffer = nullptr;
   int id;
   std::array<uint8_t, 4> sequence_id;
 
@@ -547,17 +550,18 @@ class track {
     }
   }
 
-public:
-  NOINLINE track() : global_buffer(nullptr), id(next_track_id++) {
-    thread_local bool initializing = false;
-    if (initializing) return;
-    initializing = true;
+  void construct() {
+    id = next_track_id++;
     init_trace();
     global_buffer = &*file;
     begin_block(/*first=*/true);
   }
 
-  NOINLINE ~track() { write_block(); }
+public:
+  // This cannot have a non-trivial constructor.
+  track() = default;
+
+  NOINLINE ~track() noexcept { write_block(); }
 
   // This is inline so we can see constexpr track_events.
   template <typename TrackEvent>
@@ -603,6 +607,10 @@ class track {
 
   static track& get_thread() {
     thread_local track t;
+    if (!t.constructed) {
+      t.construct();
+      t.constructed = true;
+    }
     return t;
   }
 };