Add Datetime Logger #1
Conversation
| result_json = serialise_constraints(example_constraints) | ||
| expected_json = """{"module": "smartnoise-synth", "version": "1.0.4", "constraints": {"birthdays": {"type": "_ssynth_datetime_transformer:DateTimeTransformer", "params": {"epoch": "1970-01-01T00:00:00"}}}}""" # noqa | ||
| expected_json_updated = expected_json.replace( | ||
| "1.0.4", pkg_resources.get_distribution(SSYNTH).version |
There was a problem hiding this comment.
nice! i guess we could use the same logic for the measurement pipeline in our test with opendp. Instead of updating each time we use a new version.
There was a problem hiding this comment.
ah yes ^^ let's be lazy
| # "date": ChainTransformer( | ||
| # [DateTimeTransformer(), MinMaxTransformer(nullable=False)] | ||
| # ), | ||
| "date": DateTimeTransformer(epoch="1993-06-04"), |
There was a problem hiding this comment.
not sure to fully understand the epoch. For what i understand, its the date of reference during the transformation from date to float (nb of days since reference - 1970-01-01 being 0 by default). Is it only testing this aspect?
There was a problem hiding this comment.
Here it is testing that the serialiser works also when given another start date of reference, so from what I understand in this case 0 would start the "1993-06-04".
But I am just testing the de/serialiser works not the underlying library
No description provided.