[Week10] String - 규리 #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyeoon00
reviewed
Mar 27, 2023
| BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); | ||
| StringBuilder sb = new StringBuilder(); | ||
|
|
||
| char[][] arr = new char[5][15]; |
There was a problem hiding this comment.
오...최대 15개의 글자들이라고 문제에 나와있었군요!! 저는 입력 받은 문자열 중에 최대값 따로 구해줬는데 그럴 필요가 없었네요💦
| arr[i] = br.readLine(); | ||
| } | ||
|
|
||
| while (sb.length() <= 15){ |
There was a problem hiding this comment.
한 줄의 글자 수가 15여서, sb는 최대 15*5가 될 수 있어서 틀린거 아닐까요?! 그리고 밑에 127번째 줄에서 현재 인덱스보다 문자열 길이가 큰지 검사해주고 sb에 append해주기 때문에 해당 while조건문이 없어도 맞긴 할 거 같아요!
| System.out.println("Yes"); | ||
| } else { | ||
| System.out.println("No"); | ||
| } |
There was a problem hiding this comment.
t에 대한 문자열을 for문으로 돌아주면서 s 인덱스만 증가시키면서 검사하는게 깔끔하네요!
| } | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
코드 진짜 깔끔하고 읽기도 좋네요! position객체로 left, right묶어주는거, isPalindrome을 boolean값으로 리턴해서 ||로 처리하는것도 isPalindrome함수 재사용성이 되게 높은거 같아서 잘보고 갑니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.