Skip to content

Commit

Permalink
Alias @value to @exception in Try::Error (#177)
Browse files Browse the repository at this point in the history
* Alias @value to @exception in Try::Error

This allows deconstruct to work correctly

* Update try_spec.rb to test deconstruction

* Move pattern match tests from unit to integration specs
  • Loading branch information
alexkalderimis authored Jan 7, 2025
1 parent eca0e37 commit 959efb9
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/dry/monads/try.rb
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ class Error < Try
def initialize(exception)
super()

@exception = exception
@exception = @value = exception
end

# @return [String]
Expand Down
51 changes: 51 additions & 0 deletions spec/integration/pattern_matching_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,57 @@
# frozen_string_literal: true

RSpec.describe "pattern matching" do
describe "Dry::Monads::Try" do
include Dry::Monads[:try]

context "Value" do
it "matches on the singleton array of the value when value is not an array" do
expect(
(Value(1) in [1])
).to be(true)
end

it "matches on the value when value is an array" do
expect(
(Value([1]) in [1])
).to be(true)
end

it "matches on the empty array when value is Unit" do
expect(
(Value(Dry::Monads::Unit) in [])
).to be(true)
end

it "matches on the value's keys when value acts like a hash" do
expect(
(Value({code: 101, foo: :bar}) in { code: 101 })
).to be(true)
end

it "matches on the empty hash when value doesn't act like a hash" do
expect(
(Value(:foo) in {})
).to be(true)
end
end

context "Error" do
it "matches on the singleton array of the exception" do
exception = StandardError.new("boom")
failure = Try { raise exception }

expect(
(failure in [exception])
).to be(true)

expect(
(failure in Dry::Monads::Try::Error(exception))
).to be(true)
end
end
end

describe "Dry::Monads::Result" do
include Dry::Monads[:result]

Expand Down

0 comments on commit 959efb9

Please sign in to comment.