Rewrite drone-nuget to use drone-plugin-lib #14
Conversation
Just standardize on using the dotnet executable and simplify accordingly.
|
@tboerger I feel like the plugin bits are ready for a review. I was able to successfully push to the public NuGet repository. My only open question is what to do about arm targets. I feel like they should just be ignored. You can see the tags for https://hub.docker.com/_/microsoft-dotnet-core-sdk/ they do have arm but they're not alpine images. |
|
|
||
| Drone plugin to publish files and artifacts to NuGet repository. For the usage information and a listing of the available options please take a look at [the docs](DOCS.md). | ||
| Drone plugin to publish files and artifacts to a NuGet repository. For the usage information and a listing of the available options please take a look at [the docs](DOCS.md). |
There was a problem hiding this comment.
It's linking to a deleted files
| return fmt.Errorf("file %s isn't a nuspec or a nupkg", file) | ||
| } | ||
|
|
||
| if !fileExists(file) { |
There was a problem hiding this comment.
I dislike this fileExists function
| return fmt.Errorf("could not parse source url %s: %w", p.settings.Source, err) | ||
| } | ||
|
|
||
| logrus.WithFields(logrus.Fields{ |
There was a problem hiding this comment.
Just log that while uploading?
|
|
||
| // pushPackageCmd pushes a package to the nuget repository. | ||
| func pushPackageCmd(path, name, key string) *exec.Cmd { | ||
| return exec.Command("dotnet", "nuget", "push", path, "--source", name, "--api-key", key) |
There was a problem hiding this comment.
Trace will print the api key?
There was a problem hiding this comment.
Its my understanding that if its a secret it'll end up being hidden in the log.
There was a problem hiding this comment.
With npm I was able to just create a config file that had the credentials. With Nuget the api key is always encrypted if stored in a file so its not possible for me to just replicate that.
I don't know if we would want something like a cmd library in the plugin lib. Most of this stuff was copied from drone-npm. If that's the case then we can add something that'll handle the case where we would want to control what is printed out directly.
|
With regards to supporting linux I'm thinking we just support amd64 and that's it. https://hub.docker.com/_/microsoft-dotnet-core-sdk/ there are some arm but they aren't on alpine. |
Completely redo the drone-nuget plugin to remove its usage of node.