Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build secret flag #264

Closed
wants to merge 6 commits into from
Closed

Add build secret flag #264

wants to merge 6 commits into from

Conversation

nashiox
Copy link

@nashiox nashiox commented Feb 18, 2020

Add the secret flag for build #189

Ex)

- name: build
  image: plugins/docker
  volumes:
  - name: secrets
    path: /var/run/secrets
  environment:
    DOCKER_BUILDKIT: 1
  settings:
    repo: my/repos
    secret: id=mysecret,src=/var/run/secrets/mysecret

@tboerger
Copy link

Does it make sense to provide it as a slice? It's possible to add multiple secrets, right?

@nashiox
Copy link
Author

nashiox commented Feb 18, 2020

Oops, I missed that it was a slice option.
https://github.com/moby/buildkit/blob/master/cmd/buildctl/build.go#L93-L95

Fixed it. 4940a7f

@Weasy666
Copy link

Hi! Is there an ETA when this will land?

@nashiox nashiox closed this Jan 14, 2021
@davezuch
Copy link

Why was this PR closed?

@tboerger
Copy link

I guess because it haven't been merged within a year.

@wszychta
Copy link

wszychta commented Sep 8, 2021

@tboerger @nashiox It there any chance to reopen this issue? We really need this feature to pass .netrc file into Docker build as a temporary secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants