Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow secure cookies #279

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow secure cookies #279

wants to merge 3 commits into from

Conversation

defektive
Copy link

When stripping the secure flag, it breaks cookies with SameSite=None. This PR will add an option for users to disable the default stripping of secure cookies.

It also contains a .gitignore and go fmt in a separate commits, to make it easier to see what i really changed.

@defektive
Copy link
Author

If you are serving over HTTPS this addresses #250

@ghost
Copy link

ghost commented Feb 19, 2022

why reformat all the files lol

@defektive
Copy link
Author

defektive commented Feb 19, 2022

I just ran

go fmt ./...

So they'd match the go standard. I did do it as a separate commit to make the changes easier to see. Most IDEs will auto run go fmt on save. I can drop the commit and repush if desired. Just let me know

@ghost
Copy link

ghost commented Feb 19, 2022

I just wanted to quickly view the new changes you made. I guess I didn't read the part where you said it was a separate commit, could've just opened that commit up, my bad lol.

I wouldn't touch any external code unrelated to the PR, but I'm not the maintainer nor necessarily represent their views. It's just a light nitpick, don't feel like you must make changes to your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant