Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE: DDF for Tuya trv: Essentials, Revolt, Siterwell, Nedis... #8015

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mattreim
Copy link
Contributor

@mattreim mattreim commented Nov 3, 2024

Reopened #7640

My test device:
Essentials 12011
Essentials 12011

The information is from the following page zha-device-handlers.

Tuya-thermostat

Phoscon:
Thermostat

@mattreim mattreim force-pushed the Tuya-trv branch 2 times, most recently from 5c378e4 to 8c4d9bc Compare November 3, 2024 10:35
@mattreim
Copy link
Contributor Author

mattreim commented Nov 3, 2024

Hey @Smanar, the first error has been fixed and the next one is coming and I can't find him.

@mattreim mattreim force-pushed the Tuya-trv branch 3 times, most recently from e37fb5f to 8c4d9bc Compare November 3, 2024 14:11
@Smanar
Copy link
Collaborator

Smanar commented Nov 3, 2024

Me too, I have checked your json, no typo on my side, it work

@Zehir what is the json problem ?

@Zehir
Copy link
Collaborator

Zehir commented Nov 3, 2024

Hello @Smanar , it's not the json format the issue, I need to update the error message.

The correct error is : There is no generic file for config/setvalve

@mattreim
Copy link
Contributor Author

mattreim commented Nov 3, 2024

I had already done a PR there and closed two weeks ago. Should I open it again?

@Zehir
Copy link
Collaborator

Zehir commented Nov 3, 2024

@manup @SwoopX Any idea about that ?

@mattreim
Copy link
Contributor Author

mattreim commented Nov 3, 2024

But with "public: true" it works and I can also control it externally.

@Smanar
Copy link
Collaborator

Smanar commented Nov 4, 2024

There is no generic file for config/setvalve

@mattreim you need a json file in devices\generic\items called config_setvalve_item.json with this contain

{
  "schema": "resourceitem1.schema.json",
  "id": "config/setvalve",
  "datatype": "Bool",
  "access": "RW",
  "public": true,
  "description": "XXXXXXXXXXXXXXXXXXXxx.",
  "default": false
}

And yes it can work without this file, but the github bot want this file ^^

@mattreim
Copy link
Contributor Author

mattreim commented Nov 4, 2024

@Smanar Please take a look at #7614. I reopened it.

@Smanar
Copy link
Collaborator

Smanar commented Nov 4, 2024

Ha yes ...
So wich one name you want instead of config/setvalve @SwoopX and @manup

Or he can give up and just remove this field from his DDF ?

@mattreim
Copy link
Contributor Author

mattreim commented Nov 4, 2024

I asked to rename it but the effort would be too high. I don't think it's a good idea to remove it because it's quite important and useful for use.

@SwoopX
Copy link
Collaborator

SwoopX commented Nov 7, 2024

@manup @SwoopX Any idea about that ?

@Zehir Well, the json file for that item is indeed missing and was apparently forgotten during its introduction

@mattreim
Copy link
Contributor Author

mattreim commented Nov 8, 2024

@Zehir config_setvalve_item.json is now merged.

@Zehir
Copy link
Collaborator

Zehir commented Nov 8, 2024

@Zehir config_setvalve_item.json is now merged.

Then you need to rebase this PR on the latest commit from the main branch

@mattreim
Copy link
Contributor Author

mattreim commented Nov 8, 2024

@Zehir Now comes the next error

@Zehir
Copy link
Collaborator

Zehir commented Nov 8, 2024

@Zehir Now comes the next error

It's not related to this PR but there is issue on the main branch, checking with other devs. Maybe related to #7961

@Zehir
Copy link
Collaborator

Zehir commented Nov 8, 2024

Fix was added in #7979

@mattreim
Copy link
Contributor Author

mattreim commented Nov 9, 2024

Now it works, thank you all.

Copy link
Contributor

github-actions bot commented Nov 9, 2024

Hey @mattreim, thanks for your pull request!

Tip

Modified bundles can be downloaded here.
Relative expire date

DDB changes

Modified

  • tuya/_TZE200_TYST11_trv.json : Tuya radiator thermostat ✔️

Validation

Tip

Everything is fine !

🕥 Updated for commit 068b2da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants