fix(cluster): crash in cluster migration #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
approved these changes
Jan 22, 2025
|
@adiholden please update your branch - I want to see if actions will work better. |
Signed-off-by: adi_holden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4455
The bug:
When running the RestoreStreamer::WriteBucket the iterator was not valid, pointing to a location in dash table that is not occupied.
The reason for this was that the call to FlushChangeToEarlierCallbacks when traversing the buckets can delete entires in the dash table. This can happen when we remove finalized migration which results in flush slots operation. This operation also registers a callback which was invoked in FlushChangeToEarlierCallbacks.
The fix:
When traversing the bucket in WriteBucket/SerializeBucket we first update the iterator if needed.