fix: treat single subselect properly #357

nic11 · 2022-09-22T08:43:58Z

Fixes #352

nic11 · 2022-09-22T08:45:48Z

sqlgen/expression_sql_generator_test.go

@@ -565,16 +565,16 @@ func (esgs *expressionSQLGeneratorSuite) TestGenerate_BooleanExpression() {
 			int64(1), int64(2), int64(3),
 		}},

-		expressionTestCase{val: ident.In(ae), sql: `("a" IN ((SELECT "id" FROM "test2")))`},
-		expressionTestCase{val: ident.In(ae), sql: `("a" IN ((SELECT "id" FROM "test2")))`, isPrepared: true},
+		expressionTestCase{val: ident.In(ae), sql: `("a" IN (SELECT "id" FROM "test2"))`},


There is a expressionTestCase{val: ident.Eq(ae), sql: `("a" IN (SELECT "id" FROM "test2"))`}, above, so maybe this was intended for some reason(??)

But looks strange anyway, I don't think that this should be a desired behaviour

gwd · 2023-05-14T21:25:22Z

Any chance we can get this merged? I just spent several hours trying to figure out why my query was only getting a single result, only to find the extra paren made the difference.

fix: treat single subselect properly

3ab9524

nic11 commented Sep 22, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: treat single subselect properly #357

fix: treat single subselect properly #357

nic11 commented Sep 22, 2022 •

edited

Loading

nic11 Sep 22, 2022 •

edited

Loading

gwd commented May 14, 2023

fix: treat single subselect properly #357

Are you sure you want to change the base?

fix: treat single subselect properly #357

Conversation

nic11 commented Sep 22, 2022 • edited Loading

nic11 Sep 22, 2022 • edited Loading

Choose a reason for hiding this comment

gwd commented May 14, 2023

nic11 commented Sep 22, 2022 •

edited

Loading

nic11 Sep 22, 2022 •

edited

Loading