Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #11214 #11213

Open
wants to merge 1 commit into
base: feature/10.0
Choose a base branch
from

Conversation

swapso
Copy link

@swapso swapso commented Apr 14, 2024

Fixes #11214

Link for issue: #11214

Proposed changes

  • Updated if condition to bypass base.IsHandleCreated

Regression?

  • No
Microsoft Reviewers: Open in CodeFlow

@swapso swapso requested a review from a team as a code owner April 14, 2024 10:20
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46746%. Comparing base (9c9b2e0) to head (4ec1707).
Report is 380 commits behind head on feature/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/10.0      #11213         +/-   ##
======================================================
+ Coverage      73.39203%   74.46746%   +1.07542%     
======================================================
  Files              3097        3210        +113     
  Lines            632134      666150      +34016     
  Branches          46650       51987       +5337     
======================================================
+ Hits             463936      496065      +32129     
- Misses           164802      166675       +1873     
- Partials           3396        3410         +14     
Flag Coverage Δ
Debug 74.46746% <100.00000%> (+1.07542%) ⬆️
integration 19.32092% <100.00000%> (+1.11147%) ⬆️
production 49.16549% <100.00000%> (+2.36480%) ⬆️
test 95.16751% <ø> (+0.18483%) ⬆️
unit 46.18739% <100.00000%> (+2.30696%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elachlan
Copy link
Contributor

@swapso can you update the PR description with the correct issue ID?

@elachlan elachlan added the 📭 waiting-author-feedback The team requires more information from the author label Apr 21, 2024
@swapso swapso changed the title fixed #101019 fixed #11214 Apr 24, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label Apr 24, 2024
@swapso
Copy link
Author

swapso commented Apr 24, 2024

@swapso can you update the PR description with the correct issue ID?

Hi @elachlan I have updated correct Issue ID.

@elachlan elachlan added waiting-review This item is waiting on review by one or more members of team waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed labels Apr 29, 2024
@lonitra lonitra changed the base branch from main to feature/10.0 July 23, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-team This work item needs to be discussed with team or is waiting on team action in order to proceed waiting-review This item is waiting on review by one or more members of team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font autoscaling doesn't function in .NET Core as it does in .NET Framework 4.8.
2 participants