[release/9.0.1xx] Fix writing dotnet test results when terminal logger is off #43871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-DotNet Test
untriaged
nohwnd
changed the title
baronfel
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When terminal logger is turned off we need to know it before calling msbuild to force it into mode that forwards standard output from child nodes, and disabling node reuse to stay compatible with the previous behavior.
To achieve this we need the same logic as terminal logger to detect the option, environment variables and console capability
Copying code from MSBuild here, to hopefully replace this in the future with MSBuild provided solution.
Fix microsoft/vstest#10358