Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 9.0 TFM to Microbenchmarks #3504

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Conversation

CarnaViire
Copy link
Member

@CarnaViire CarnaViire commented Nov 23, 2023

This is an attempt to add net9.0 TFM to microbenchmarks csproj, otherwise it is impossible to run them for .NET 9 in the way it's suggested by src/benchmarks/micro/README.md:

➜ dotnet run -c release -f net9.0

C:\Users\knatalia\dev\git\tmp\performance\.dotnet\sdk\9.0.100-alpha.1.23572.8\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1005: Assets file
 'C:\Users\knatalia\dev\git\tmp\performance\artifacts\obj\MicroBenchmarks\project.assets.json' doesn't have a target for 'net9.0'. Ensure that restore has run and that you have included 'net9.
0' in the TargetFrameworks for your project. [C:\Users\knatalia\dev\git\tmp\performance\src\benchmarks\micro\MicroBenchmarks.csproj::TargetFramework=net9.0]

The build failed. Fix the build errors and run again.

Contributes to dotnet/crank#662

@CarnaViire
Copy link
Member Author

CI failures are unrelated (they are the same as in e.g. #3495)

@cincuranet
Copy link
Contributor

Thanks!

@cincuranet cincuranet merged commit f0e8d56 into dotnet:main Nov 25, 2023
30 of 35 checks passed
@adamsitnik adamsitnik mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants