Skip to content

Commit

Permalink
revert .mjs renaming
Browse files Browse the repository at this point in the history
  • Loading branch information
mkhamoyan committed Jul 30, 2024
1 parent 11ce41a commit c7b3040
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/benchmarking-workflow-dotnet-runtime.md
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ In order to run the benchmarks against local [dotnet/runtime](https://github.com

This would produce `/path/to/dotnet/runtime/artifacts/bin/dotnet-latest`, which should be used to run the benchmarks.

3. And you need `/path/to/dotnet/runtime/src/mono/browser/test-main.mjs`
3. And you need `/path/to/dotnet/runtime/src/mono/browser/test-main.js`

#### Install v8 engine

Expand Down
4 changes: 2 additions & 2 deletions scripts/benchmarks_local.py
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,9 @@ def generate_all_runtype_dependencies(parsed_args: Namespace, repo_path: str, co
src_dir_built_nugets = os.path.join(repo_path, "artifacts", "packages", "Release", "Shipping") # Goal is to copy Microsoft.NET.Sdk.WebAssembly.Pack*, Microsoft.NETCore.App.Ref*, either need to do the shipping folder or glob
copy_directory_contents(src_dir_built_nugets, dir_bin_wasm)
# browser folder was extracted from wasm folder here: https://github.com/dotnet/runtime/pull/95940, so we need to check both locations for which to use (Dec, 2023)
src_file_test_main = glob.glob(os.path.join(repo_path, "src", "mono", "*", "test-main.mjs"))[0]
src_file_test_main = glob.glob(os.path.join(repo_path, "src", "mono", "*", "test-main.js"))[0]
dest_dir_wasm_data = os.path.join(dir_bin_wasm, "wasm-data")
dest_file_test_main = os.path.join(dest_dir_wasm_data, "test-main.mjs")
dest_file_test_main = os.path.join(dest_dir_wasm_data, "test-main.js")
if not os.path.exists(dest_dir_wasm_data):
os.makedirs(dest_dir_wasm_data)
shutil.copy2(src_file_test_main, dest_file_test_main)
Expand Down
2 changes: 1 addition & 1 deletion src/benchmarks/micro/MicroBenchmarks.Wasm.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<WasmGenerateRunV8Script>true</WasmGenerateRunV8Script>
<WasmMainJSPath>$(WasmDataDir)\test-main.mjs</WasmMainJSPath>
<WasmMainJSPath>$(WasmDataDir)\test-main.js</WasmMainJSPath>
<TrimMode>partial</TrimMode>
<JsonSerializerIsReflectionEnabledByDefault>true</JsonSerializerIsReflectionEnabledByDefault>
<WasmNativeStrip>false</WasmNativeStrip>
Expand Down

0 comments on commit c7b3040

Please sign in to comment.