Remove unused ProjectDiagnosticAnalyzer (#8304)

* Remove unused ProjectDiagnosticAnalyzer * Update proj file
dotnet · Jan 23, 2020 · 70883fb · 70883fb
1 parent ba87a35
commit 70883fb
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 90 deletions.
diff --git a/vsintegration/src/FSharp.Editor/Diagnostics/ProjectDiagnosticAnalyzer.fs b/vsintegration/src/FSharp.Editor/Diagnostics/ProjectDiagnosticAnalyzer.fs
diff --git a/vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj b/vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj
@@ -61,7 +61,6 @@
     <Compile Include="Debugging\BreakpointResolutionService.fs" />
     <Compile Include="Debugging\LanguageDebugInfoService.fs" />
     <Compile Include="Diagnostics\DocumentDiagnosticAnalyzer.fs" />
-    <Compile Include="Diagnostics\ProjectDiagnosticAnalyzer.fs" />
     <Compile Include="Diagnostics\SimplifyNameDiagnosticAnalyzer.fs" />
     <Compile Include="Diagnostics\UnusedDeclarationsAnalyzer.fs" />
     <Compile Include="Diagnostics\UnusedOpensDiagnosticAnalyzer.fs" />

diff --git a/vsintegration/tests/UnitTests/ProjectDiagnosticAnalyzerTests.fs b/vsintegration/tests/UnitTests/ProjectDiagnosticAnalyzerTests.fs
@@ -32,34 +32,3 @@ type ProjectDiagnosticAnalyzerTests()  =
 
         let args = mkProjectCommandLineArgs (dllName, [fileName])
         checker.GetProjectOptionsFromCommandLineArgs (projectName, args)
-
-#if PROJECT_ANALYSIS
-    [<Test>]
-    member public this.ProjectDiagnosticsDontReportJustProjectErrors_Bug1596() =
-        // https://github.com/Microsoft/visualfsharp/issues/1596
-        let fileContents = """
-let x = 3
-printf "%d" x
-"""
-        let options = CreateProjectAndGetOptions(fileContents)
-        let additionalOptions = {options with OtherOptions = Array.append options.OtherOptions [| "--times" |]}
-
-        let errors = FSharpProjectDiagnosticAnalyzer.GetDiagnostics(additionalOptions)  |> Async.RunSynchronously
-        Assert.AreEqual(1, errors.Length, "Exactly one warning should have been reported")
-
-        let warning = errors.[0]
-        Assert.AreEqual(DiagnosticSeverity.Warning, warning.Severity, "Diagnostic severity should be a warning")
-        Assert.AreEqual("The command-line option 'times' is for test purposes only", warning.GetMessage())
-
-    [<Test>]
-    member public this.ProjectDiagnosticsShouldNotReportDocumentErrors_Bug1596() =
-        // https://github.com/Microsoft/visualfsharp/issues/1596
-        let fileContents = """
-let x = "string value that cannot be printed with %d"
-printf "%d" x
-"""
-        let options = CreateProjectAndGetOptions(fileContents)
-
-        let errors = FSharpProjectDiagnosticAnalyzer.GetDiagnostics(options)  |> Async.RunSynchronously
-        Assert.AreEqual(0, errors.Length, "No semantic errors should have been reported")
-#endif