Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify timestamp display in console logs #5455

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 27, 2024

Description

Following up to other console logs date changes, this PR reduces the amount of date information shown on the console logs page.

  • Remove env var that adds timestamp to console logs. Not required when DCP adds the timestamp.
  • Simplifies timestamp written to the UI to not include milliseconds. This is similar to tooling such as Docker for Windows which only shows times to the second in their console log view.
  • Adds a tooltip to the timestamp

Before:
image

After:
image

I think a future improvement to this page would be to have a setting for controlling timestamp display:

  • Full (include milliseconds)
  • Simple (default)
  • Off

Fixes #5454

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@drewnoakes
Copy link
Member

I think a future improvement to this page would be to have a setting for controlling timestamp display:

  • Full (include milliseconds)
  • Simple (default)
  • Off

I like this idea. Can you file an issue so we don't lose track of it.

@JamesNK JamesNK requested a review from mitchdenny as a code owner August 27, 2024 04:49
@JamesNK JamesNK force-pushed the jamesnk/console-logs-date-format branch from d5e3d7f to 7a1a574 Compare August 27, 2024 05:44
@JamesNK JamesNK enabled auto-merge (squash) August 27, 2024 05:48
@JamesNK JamesNK force-pushed the jamesnk/console-logs-date-format branch from 7a1a574 to a117d04 Compare August 27, 2024 06:05
@JamesNK JamesNK requested a review from ReubenBond as a code owner August 27, 2024 06:31
@JamesNK JamesNK merged commit f5d9f80 into main Aug 27, 2024
11 checks passed
@JamesNK JamesNK deleted the jamesnk/console-logs-date-format branch August 27, 2024 07:30
@drewnoakes
Copy link
Member

I think a future improvement to this page would be to have a setting for controlling timestamp display:

  • Full (include milliseconds)
  • Simple (default)
  • Off

I like this idea. Can you file an issue so we don't lose track of it.

Did this happen?

@JamesNK
Copy link
Member Author

JamesNK commented Aug 29, 2024

#5456
#5457
#5458

@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce precision of timestamp on console logs page
2 participants