This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Color: add overloads so int
does not get clamped like a float
#310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds overloads for the
Color
constructor,FromRgb()
, andFromRgba()
that acceptint
.Reported by @PureWeen in #253 and @davidbritch in #308, there exists a problem where
int
values (expected to be 0-255) are interpreted asfloat
and clamped between 0 and 1.0, demonstrated here:Full source code