Optimise data transfer between principle and worker procs #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosaboy
force-pushed
the
ipc-improvements
branch
2 times, most recently
from
c69262b
to
ab167ae
Compare
SearchResultMinimal is used to transder results between the worker processes and the main collector. As a result it must be a small as possible in order to keep transfer fast and memory footprint low. There were several unnecessary variables being stored and duplicated in this object that have now been removed maing the transfer faster and using less memory. Transfers are also batched so as to reduce interruption on searches. Also removes unnecssary use of multiprocessing.Queue for single thread usecase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchResultMinimal is used to transder results between the worker processes and the main collector. As a result it must be a small as possible in order to keep transfer fast and memory footprint low. There were several
unnecessary variables being stored and duplicated in this object that have now been removed maing the transfer faster and using less memory. Transfers are also batched so as to reduce interruption on searches.