Merge pull request #55 from yg-i/master

protect against the scenario when langlinks is undefined
dopecodez · Jan 13, 2024 · 121a05e · 121a05e
2 parents b6dd295 + c65a4fc
commit 121a05e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/source/page.ts b/source/page.ts
@@ -665,7 +665,7 @@ export const langLinks = async (title: string, listOptions?: listOptions): Promi
         languageOptions = setPageIdOrTitleParam(languageOptions, title);
         const response = await request(languageOptions, listOptions?.redirect);
         const pageId = setPageId(languageOptions, response);
-        const result = response.query.pages[pageId].langlinks.map((link: any) => {
+        const result = (response.query.pages[pageId].langlinks ?? []).map((link: any) => {
             return {
                 lang: link.lang,
                 title: link['*'],
@@ -881,4 +881,4 @@ export const citation = async (query: string, format?: citationFormat, language?
    }
 }
 
-export default Page;
+export default Page;
diff --git a/test/langlinks.test.ts b/test/langlinks.test.ts
@@ -58,6 +58,12 @@ test('Returns empty if no lang links are available', async () => {
     expect(result).toStrictEqual([]);
 });
 
+test('Returns empty if lang links object itself is not available', async () => {
+    requestMock.mockImplementation(async () => { return { query: { pages: {404: {}} } } });
+    const result = await langLinks("Test");
+    expect(result).toStrictEqual([]);
+});
+
 test('Returns with results an array of langLinksResult object', async () => {
     requestMock.mockImplementation(async () => { return { query: { pages: langLinkskMock } } });
     const result = await langLinks("Test");