bugfix in UtilitiesClient.stream_upload #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In UtilitiesClient.stream_upload, the domo stream upload part api expects part_id to be contiguous. It seems to tolerate some discontinuities, but when uploading a large dataset the api eventually returns an error that there are too many gaps in the part_ids. This commit fixes this by using `i` as the part_id (instead of `start`) which will be contiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In UtilitiesClient.stream_upload, the domo stream upload part api expects part_id to be contiguous. It seems to tolerate some discontinuities, but when uploading a large dataset the api eventually returns an error that there are too many gaps in the uploaded part_ids. This commit fixes this by using
ias the part_id (instead ofstart) which will be contiguous.I have only tested this code change by running it in my code, where it fixed the issue. If there is other testing that needs to be done, let me know how I can do that.