Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and cleanup #10

Merged
merged 2 commits into from
Oct 16, 2021
Merged

Fix and cleanup #10

merged 2 commits into from
Oct 16, 2021

Conversation

lpaulsen93
Copy link
Member

This fixes array operations and includes some code cleanup.

@Klap-in
Copy link
Member

Klap-in commented Dec 21, 2020

@lpaulsen93 looks good. You have test the changes?

@lpaulsen93
Copy link
Member Author

lpaulsen93 commented Dec 21, 2020

@Klap-in I did a short test and that seemed to work fine for me. But I don't use the plugin myself.

@Klap-in
Copy link
Member

Klap-in commented Dec 21, 2020

Should this address #9?

@lpaulsen93 lpaulsen93 mentioned this pull request Dec 22, 2020
@lpaulsen93
Copy link
Member Author

Could be but I am not sure so I asked for testing in #9.

@Klap-in Klap-in merged commit 3a1b04e into dokufreaks:master Oct 16, 2021
@Klap-in
Copy link
Member

Klap-in commented Oct 16, 2021

@lpaulsen93

The unit tests show these errors here (locally) (unit test are not enabled at github..)

Failed asserting that null matches expected 'bar'.
Expected :bar
Actual   :null
<Click to see difference>

 /../dokuwiki/lib/plugins/meta/_test/rendering.test.php:29
 

Failed asserting that two strings are equal.
Expected :'My abstract'
Actual   :'Persistent description'
<Click to see difference>

 /../dokuwiki/lib/plugins/meta/_test/rendering.test.php:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants