Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dokku_clone: add version parameter and switch to git:sync #98

Merged
merged 17 commits into from
Sep 2, 2021

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Feb 2, 2021

fixes #88
fixes #94

Use new git:sync command under the hood for dokku_clone.
Also, start reusing code between modules by placing code inside the module_utils folder.
Further additions for fixing tests during the verify stage.

Note: This requires dokku >= 0.23.0 and will break the dokku_clone command for previous dokku releases.
I therefore suggest to

  • first merge the other PRs that are in the pipeline
  • then make anew release of ansible-dokku
  • then merge this PR

@ltalirz ltalirz force-pushed the issue_88_clone_version branch 6 times, most recently from fe7b1de to a6200cb Compare February 3, 2021 10:02
@ltalirz ltalirz changed the title dokku_clone: add version parameter dokku_clone: add version parameter and switch to git:sync Feb 3, 2021
@ltalirz
Copy link
Member Author

ltalirz commented Feb 3, 2021

Ran into a molecule bug.
Opened ansible/molecule#3045

@caillou
Copy link

caillou commented May 27, 2021

Would it makes sense to expose the --build option of dokku git:sync? C.f. documentations:

By default, this command [dokku git:sync] does not trigger an application build. To do so during a git:sync, specify the --build flag.

@ltalirz
Copy link
Member Author

ltalirz commented May 27, 2021

thanks for the suggestion @caillou , that would seem to make a lot of sense.

I finally got a reply on the molecule issue some time ago, just haven't found the time to sit down and try the fixes.
I'll try to make the time in the coming days and get this merged

@ltalirz
Copy link
Member Author

ltalirz commented May 27, 2021

P.S. Would you be interested in reviewing this PR once it's ready?

@ltalirz ltalirz force-pushed the issue_88_clone_version branch 4 times, most recently from 0c08325 to a4800e0 Compare August 31, 2021 12:25
Use workaround for importing the `library` and `module_utils` in the
`verify.yml` playbook without actually running the role.
@ltalirz
Copy link
Member Author

ltalirz commented Sep 1, 2021

hi @caillou , I finally found the time to get back to this PR.
I've now switched to the --build option of git:sync, would you mind giving this a review to see whether it fits what you had in mind?

dokku_clone will remain building by default but it can now be turned off by passing build: false.

You don't necessarily need to go through all changes; I'm mainly concerned with library/dokku_clone.py

molecule/default/verify.yml Outdated Show resolved Hide resolved
@ltalirz
Copy link
Member Author

ltalirz commented Sep 1, 2021

@josegonzalez if you manage to have a quick look at library/dokku_clone.py as well that may be useful

I'll probably merge this tomorrow since it's going to be useful for the blog article

@ltalirz
Copy link
Member Author

ltalirz commented Sep 2, 2021

I'm going ahead and merging this; happy to include updates in follow-up PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support new git:sync command dokku_clone: add version parameter?
2 participants