Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/dfs #110

Merged
merged 6 commits into from
Oct 17, 2024
Merged

feat/dfs #110

merged 6 commits into from
Oct 17, 2024

Conversation

guha-rahul
Copy link
Contributor

Closes #97

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Add a dedicated CI job for new examples
  • Performed self-review of the code

bal7hazar
bal7hazar requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@bal7hazar bal7hazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the attempt, however I don't think it is a DFS algo, it is just a brute force one I think. As suggested in a comment below, you should probably try a recursive approach.

crates/map/src/finders/dfs.cairo Outdated Show resolved Hide resolved
crates/map/src/finders/dfs.cairo Outdated Show resolved Hide resolved
crates/map/src/finders/dfs.cairo Outdated Show resolved Hide resolved
bal7hazar
bal7hazar approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@bal7hazar bal7hazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, this one it is indeed a DFS, just few minor changes and we good

crates/map/src/finders/dfs.cairo Show resolved Hide resolved
crates/map/src/finders/dfs.cairo Outdated Show resolved Hide resolved
crates/map/src/finders/dfs.cairo Outdated Show resolved Hide resolved
crates/map/src/finders/dfs.cairo Outdated Show resolved Hide resolved
bal7hazar
bal7hazar approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@bal7hazar bal7hazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.
This is very good, thank you for the contribution

@bal7hazar bal7hazar merged commit 0b780c0 into dojoengine:main Oct 17, 2024
10 checks passed
@guha-rahul
Copy link
Contributor Author

@bal7hazar grateful for the guidance!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bal7hazar bal7hazar bal7hazar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Depth-first search pathfinding algorithm
2 participants
@guha-rahul @bal7hazar