Fix static page links #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
fix/static-links
branch
from
5cfe74d
to
f92caa5
Compare
greg0ire
approved these changes
Oct 15, 2024
Static pages do not have an source to find references, so static html links are used. Guides does see them as invalid links. This new resolver allows us to accept the static links as valid and uses the targetreference as url.
jaapio
force-pushed
the
fix/static-links
branch
from
f92caa5
to
8e2b34f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static pages do not have an source to find references, so static html links are used. Guides does see them as invalid links. This new resolver allows us to accept the static links as valid and uses the targetreference as url.