Schedule the Algolia search index build #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Sep 2, 2023
.github/workflows/deployment.yml
Outdated
| @@ -49,9 +54,15 @@ jobs: | |||
| run: "yarn install" | |||
|
|
|||
| - name: "Prepare Website files" | |||
| if: "inputs.search-index-only == false" | |||
There was a problem hiding this comment.
inputs.search-index-only is guaranteed to be a boolean and therefore does not need to be compared to other booleans, it can be used directly or negated.
Suggested change
| if: "inputs.search-index-only == false" | |
| if: "! inputs.search-index-only" |
.github/workflows/deployment.yml
Outdated
| run: "bin/console --env=${{ inputs.environment }} build-all" | ||
|
|
||
| - name: "Build search index" | ||
| if: "inputs.search-index-only == true" |
There was a problem hiding this comment.
Suggested change
| if: "inputs.search-index-only == true" | |
| if: "inputs.search-index-only" |
.github/workflows/deployment.yml
Outdated
| - name: "Deploy to ${{ inputs.environment }}" | ||
| if: "inputs.search-index-only == false" |
There was a problem hiding this comment.
Suggested change
| if: "inputs.search-index-only == false" | |
| if: "! inputs.search-index-only" |
SenseException
force-pushed
the
algolia-workflow
branch
from
c187550
to
6f4694d
Compare
greg0ire
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #417 the first step to a reoccurring search index build can happen in a monthly cronjob.