[Bugfix] Do not call non-static method as static method #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,8 +62,10 @@ public function isOptional() | |||
| */ | |||
| public function warmUp($cacheDir) | |||
| { | |||
| $helper = new UniqueNodeTypeHelper(); | |||
|
|
|||
There was a problem hiding this comment.
there seems to be trailing whitespace here, styleci is unhappy with this line.
|
hm , but the PR you link is adding that class. did we maybe not sync the PR on the bundle with the latest version of the lib PR? the reasoning is that static methods make it hard to customize things. instantiating locally is not helping much either, but at least the road to making it more flexible is open with this pattern. |
dbu
referenced
this pull request
Dec 14, 2015
|
so indeed, they went out of sync and we seem to not have a test for the cache warmer. can you please fix the CS issue @wouterj ? |
|
done |
dbu
added a commit
that referenced
this pull request
Dec 15, 2015
[Bugfix] Do not call non-static method as static method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static was removed from this method in 1.3: doctrine/phpcr-odm#667 (not sure why though) This now errors when warming up the cache.