deb: explicitly install docker-ce-cli, scan-plugin, and docker-ce #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
install_recommends
branch
2 times, most recently
from
5771251 to
eeace91
Compare
|
@chris-crone @glours PTAL |
chris-crone
reviewed
Jun 3, 2021
thaJeztah
force-pushed
the
install_recommends
branch
from
eeace91 to
a5a7d55
Compare
|
rebased, after #236 was merged |
chris-crone
previously approved these changes
Jun 3, 2021
thaJeztah
commented
Jun 3, 2021
install.sh
Outdated
| command_exists() { | ||
| command -v "$@" > /dev/null 2>&1 | ||
| } | ||
|
|
||
| # is_at_least_version checks if the version specified in $VERSION is at least |
There was a problem hiding this comment.
oh! forgot to update this comment (renamed the function at some point); let me fix
The scripts is using "--no-install-recommends" to provide a more minimal install, and to prevent installing "latest" version of (e.g.) the engine when installing the CLI. This patch: - adds some utilities to compare versions - skips CLI-version discovery on older versions (before 18.09) which did not have separate packages for the CLI - on versions 20.10 and up (or if no version was specified), also install the scan cli plugin (support for cli plugins was added in docker 19.03, but not installing on that version by default)) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
install_recommends
branch
from
a5a7d55 to
92cec07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal ticket: POS-27
supersedes / replaces #195 (except for the "containerd.io" part)
closes #195
The scripts is using "--no-install-recommends" to provide a more minimal install, and to prevent installing "latest" version of (e.g.) the engine when installing the CLI.
This patch: