Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configs.file's and secrets.file's on remote docker hosts #12251

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Oct 30, 2024

  1. Add support for configs.file's and secrets.file's on remote docker hosts

    Copy configs.file's and secrets.file's instead of bind-mounting them to
    make it possible to use file configs when working with remote docker
    hosts (like setting DOCKER_HOST to a ssh address or setting docker
    context)
    
    Includes support for config.files and secrets.files as directories.
    
    Note that file.Content as source of secrets is denied elsewhere with the
    error "validating docker-compose.yml: secrets.content_secret Additional
    property content is not allowed", but it is implemented here in case
    this restriction is liften in the future.
    
    Configs and secrets from environment is also handled as plain content
    inserted into target file.
    
    implements: docker#11867
    andoks committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ff5adb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Fix configs and secrets relative target logic

    If target is relative it should be joined with target base, not
    concatenated.
    andoks committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5399b92 View commit details
    Browse the repository at this point in the history