In Alpine 3.21 bump llvm version #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
changed the title
tianon
reviewed
Dec 6, 2024
Dockerfile-alpine.template
Outdated
| {{ def llvmver: "15" -}} | ||
| {{ | ||
| def llvmver: | ||
| if alpine_version | split(".")[1] | tonumber < 21 then |
There was a problem hiding this comment.
I don't like the implicit 3.x assumption here 😅 Maybe something like this?
Suggested change
| if alpine_version | split(".")[1] | tonumber < 21 then | |
| if alpine_version | split(".") | map(tonumber) < [3, 21] then |
$ jq -rnc '
"2.22", "3.20", "3.21", "3.22", "4.0",
"2.22.1", "3.20.1", "3.21.1", "3.22.1", "4.0.1"
| "\(.): \(split(".") | map(tonumber) < [3, 21])"
'
2.22: true
3.20: true
3.21: false
3.22: false
4.0: false
2.22.1: true
3.20.1: true
3.21.1: false
3.22.1: false
4.0.1: false
tianon
approved these changes
Dec 6, 2024
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 7, 2024
Changes: - docker-library/postgres@1577814: Merge pull request docker-library/postgres#1299 from infosiftr/alpine - docker-library/postgres@17818f2: In Alpine 3.21 bump llvm version - docker-library/postgres@0f542bc: Merge pull request docker-library/postgres#1298 from paolobarbolini/alpine3.21 - docker-library/postgres@1075ab7: Update Alpine to 3.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1296
Also drops Alpine 3.19Now just the llvm bump partThis should be purely additive to #1298, so we can merge that first once the Alpine images are available for testing.