-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13 add cppfmu as submodule #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
However I am not able to test it easily because of the versioning problems in conan.
If everything still works as normal then it is probably done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When pulling cppfmu as submodule I get Pylance errors in the conanfile.py
. These errors are mainly that it disagrees with the typing of variables with the functions they are used in.
I am using python 3.12.
Does these errors appear for other python verisons?
And does the tool still work correctly? I do not have the new verison of onnxruntime to test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with our hosted version of conan and then it all worked (though it still has the python recursive error), so I created this PR - so I assume it is all ok. But we can also leave this PR open until the conan thing is fixed for all.
I am unsure w.r.t. the pylance errors, did it not show those before? I was gonna check wrt python rmtree errors in other branch, will check there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it seems that there was no conanfile.py amongst the files from cppfmu that were in the repo. So I reckon that it is irrelevant then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified again that it works here, merging branch, and we can create new issues if needed.
Resolves task 1 and 2 of #13