Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13 add cppfmu as submodule #48

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

StephanieKemna
Copy link
Collaborator

Resolves task 1 and 2 of #13

  • Adding cppfmu as a submodule instead of adding the checked out files.
  • Edited README with instructions for getting submodule
  • Update CMAKE version to get rid of warning, and remove warnings-as-errors flags

@StephanieKemna StephanieKemna added the enhancement New feature or request label Jul 17, 2024
@StephanieKemna StephanieKemna self-assigned this Jul 17, 2024
@StephanieKemna StephanieKemna linked an issue Jul 17, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@KristofferSkare KristofferSkare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

However I am not able to test it easily because of the versioning problems in conan.

If everything still works as normal then it is probably done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When pulling cppfmu as submodule I get Pylance errors in the conanfile.py. These errors are mainly that it disagrees with the typing of variables with the functions they are used in.

I am using python 3.12.

Does these errors appear for other python verisons?
And does the tool still work correctly? I do not have the new verison of onnxruntime to test it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with our hosted version of conan and then it all worked (though it still has the python recursive error), so I created this PR - so I assume it is all ok. But we can also leave this PR open until the conan thing is fixed for all.

I am unsure w.r.t. the pylance errors, did it not show those before? I was gonna check wrt python rmtree errors in other branch, will check there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it seems that there was no conanfile.py amongst the files from cppfmu that were in the repo. So I reckon that it is irrelevant then.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified again that it works here, merging branch, and we can create new issues if needed.

@StephanieKemna StephanieKemna merged commit e9906b5 into main Jul 22, 2024
22 checks passed
@StephanieKemna StephanieKemna deleted the 13-add-cppfmu-as-submodule branch November 8, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cppfmu as submodule
2 participants