SSL server certificate validation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced usage of `urllib2` with `requests`, using explicit option to disable SSL certificate validation (for now).
Implemented two new options on the configuration file: * `VERIFY`: if true, will make the server certificate be validated as a browser would. Defaults to no validation for backwards compatibility with previous version. * `CA_BUNDLE`: path to file containing additional certificate(s) to consider valid, such as a self-signed certificate used by your server.
Following structure of previous code, which allows different DnsdbClient instances to behave differently if the class is ever used by more complex code.
|
Thank you for your contribution. As this PR introduces a new dependency we will need to consider it carefully before we merge. |
|
Of course. It's a pleasure to help. Please let me know if you have any comments on the code since I'm rather new to Python and would love to learn about any mistakes I might have made. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to allow the DNSDB client to:
Also updated the configuration file reader to allow for two new variables
VERIFYandCA_BUNDLEto use the new functionality.Was able to implement this with very little code by migrating from
urllib2torequestsfor HTTP queries.