Skip to content

Commit

Permalink
Merge pull request #16 from dnnrly/feature/linting
Browse files Browse the repository at this point in the history
Fix linting in actions
  • Loading branch information
dnnrly authored May 21, 2022
2 parents 962ea2d + c87802a commit 69ae218
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 3 deletions.
27 changes: 27 additions & 0 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: golangci-lint
on:
push:
tags:
- v*
branches:
- master
- main
pull_request:
permissions:
contents: read
# Optional: allow read access to pull request. Use with `only-new-issues` option.
# pull-requests: read
jobs:
golangci:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v3
with:
go-version: 1.17
- uses: actions/checkout@v3
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v1.46
2 changes: 0 additions & 2 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
run: make deps
- name: Unit test
run: make ci-test
- name: Linting
run: make lint
- name: Acceptance test
run: make build acceptance-test-docker
- name: Upload coverage to Codecov
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ clean-deps:
mkdir -p ./tmp

.PHONY: deps
deps: ./bin/tparse ./bin/golangci-lint
deps: ./bin/tparse
go get -v ./...
go mod tidy

Expand Down

0 comments on commit 69ae218

Please sign in to comment.