Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.Support for a new flag --strategy to remove vowels from input if no… #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VishalVatsal97
Copy link

… match is found. 2. Added new tests for the modified Match function.

Description

This change introduces a new flag called --strategy(-r) to attempt to remove vowels from the input string if no match is found. Introducing a flag instead of a command was easier to implement with the current structure , also it provides more flexibility to add new strategies in the future

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Running existing tests
  • Created new tests

Checklist:

  • My code has been linted (make lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased my branch to include the latest changes from master

… match is found. 2. Added new tests for the modified Match function.
@dnnrly
Copy link
Owner

dnnrly commented Oct 1, 2020

Hi, I had a go at adding strategies and got it working. It might make your work easier.

If you're interested in using it then just rebate on top of master end just add your own strategy.

And I am really grateful for the effort you've put I so far and I hope this will make your life easier!

@VishalVatsal97
Copy link
Author

Hi, I had a go at adding strategies and got it working. It might make your work easier.

If you're interested in using it then just rebate on top of master end just add your own strategy.

And I am really grateful for the effort you've put I so far and I hope this will make your life easier!

Ah..Thanks I will add the removeVowel strategy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants