Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpg integration is improved #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

litch
Copy link

@litch litch commented Sep 12, 2016

We operate PRM via another controlling process (a web app) that does not have access to tty. However, without access to tty, gpg fails, and the release is not signed - leading to all kinds of problems. This was also experienced here, it seems:

#69

While adding the tty flag, we found that though gpg_passphrase is set to false by Clamp, the logic seems to be predicated on it being nil.

Result of a prm invocation without a passphrase:

sign_cmd = echo 'false' | gpg --digest-algo \"SHA256\" -u <KeyID> --passphrase-fd 0 --yes --output Release.gpg -b Release

An unprotected key doesn't seem to mind if you pass it the wrong password, so it's possible to eliminate the third branch entirely, but that seems sloppy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant