Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We operate
PRM
via another controlling process (a web app) that does not have access to tty. However, without access totty
, gpg fails, and the release is not signed - leading to all kinds of problems. This was also experienced here, it seems:#69
While adding the tty flag, we found that though
gpg_passphrase
is set tofalse
byClamp
, the logic seems to be predicated on it beingnil
.Result of a prm invocation without a passphrase:
An unprotected key doesn't seem to mind if you pass it the wrong password, so it's possible to eliminate the third branch entirely, but that seems sloppy.